Change default signature level from None to Overloads #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1481 +/- ##
============================================
+ Coverage 64.45% 64.46% +0.01%
- Complexity 1936 1939 +3
============================================
Files 494 494
Lines 28168 28168
Branches 5598 5598
============================================
+ Hits 18156 18159 +3
+ Misses 7754 7750 -4
- Partials 2258 2259 +1 ☔ View full report in Codecov by Sentry. |
|
Capt-Mac
approved these changes
Dec 20, 2024
brynrhodes
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonedefault for Signature level can cause the CQL compiler to generate ELM that's ambiguous at runtime. This PR changes the default to the minimum level to ensure the generated ELM is unambiguous for overloads.